[Rspamd-Users] Ignoring mail forward servers & spamtrap Envelope multiple addresses

[Tobias Mädel]

Hi,

I took a look at the spamtrap.lua plugin and found the comment in line
113, stating that:
"-- Do not risk a FP by checking for more than one recipient"

I still replaced the:
-  if rcpts and #rcpts == 1 then
-    target = rcpts[1]['addr']:lower()	
with:
+  for _,sr in ipairs(rcpts) do
+    target = sr['addr']:lower()

which now causes the expected behavior for me.
The mail is now trained by the spam trap every time and it seems to work
as expected.

One side effect is that emails with multiple recipients all listed in
the spam trap now get hit with the SPAMTRAP symbol multiple times.
That's okay (and maybe even desired?) in my application.

When using a map to lookup mail addresses, this could be fixed by
returning after the first positive lookup.
The redis lookups are done async, though and I'm not too sure on how to
get the expected behavior of only one positive lookup (without chaining
the callbacks).

Maybe one of the devs can bring a bit more insight into why this was
written the way it is.

Thanks,
Tobias