[Rspamd-Users] Rspamd 1.8.3 'rcl parse error' "MX_MISSING"

[Vsevolod Stakhov]

Sophie,

Please refrain from top posting in mailing lists, it makes it impossible
to write follow ups. My *real* reply is below your message.

On 03/12/2018 17:33, Sophie Loewenthal wrote:
> Hi Bill,  
> 
> I moved the MX_* into actions.conf around v1.8.1, and mine now has this:
> 
> # rspamadm configdump metric
> *** Section metric ***
> 
> *** End of section metric ***
> 
> 
> # rspamadm configdump actions
> *** Section actions ***
> add_header = 6;
> reject = 14;
> rewrite_subject = 6;
> subject = "***SPAM*** %s";
> metrics {
>     symbol {
>         MX_MISSING {
>             one_shot = "true";
>             description = "No MX record";
>             score = 1.500000;
>         }
>         MX_INVALID {
>             one_shot = "true";
>             description = "No connectable MX";
>             score = 1;
>         }
>         MX_GOOD {
>             one_shot = "true";
>             description = "MX was ok";
>             score = -0.500000;
>         }
>     }
> }
> greylist = null;
> 
> *** End of section actions ***
> 
> Maybe this helps.
> 
>  # cat actions.conf 
>     reject = 14;
>     add_header = 6;
>     rewrite_subject = 6;
>     subject = "***SPAM*** %s";
>     greylist = null; 
> 
> metrics {
> symbol "MX_INVALID" {
>   score = 1.0;
>   description = "No connectable MX";
>   one_shot = "true"; }
> symbol "MX_MISSING" {
>   score = 1.5;
>   description = "No MX record";
>   one_shot = "true"; }
> symbol "MX_GOOD" {
>   score = -0.5;
>   description = "MX was ok";
>   one_shot = "true"; }
> }
> 
> 
> 
> 
> 
> 
>> On 3 Dec 2018, at 18:25, Bill Pye via Users <users at lists.rspamd.com> wrote:
>>
>> I've just upgraded a test server to Rspamd 1.8.3 and I'm seeinhg the followin error:
>>
>> rspamadm configdump metric
>> rcl parse error: one_shot attribute is not boolean for symbol: 'MX_MISSING'
>>
>> with the following in the log file:
>>
>> 2018-12-03 17:41:03 #7689(main) lua; lua_cfg_transform.lua:121: overriding group local from the legacy metric settings
>> 2018-12-03 17:41:03 #7689(main) lua; lua_cfg_transform.lua:159: group excessqp has no symbols
>> 2018-12-03 17:41:03 #7689(main) lua; lua_cfg_transform.lua:159: group excessb64 has no symbols
>> 2018-12-03 17:41:03 #7689(main) cfg; rspamd_rcl_maybe_apply_lua_transform: configuration has been transformed in Lua
>> 2018-12-03 17:41:03 #7689(main) <nuprt1>; cfg; rspamd_config_read: rcl parse error: one_shot attribute is not boolean for symbol: 'MX_MISSING'
>>
>> This was working in the previous 1.8.2 release, is it a bug or has something changed?
>>
>>
>> Regards
>>
>>
>>
>> Bill
>>
>> -- 
>> Users mailing list
>> Users at lists.rspamd.com
>> https://lists.rspamd.com/mailman/listinfo/users
> 

"true" is not a boolean, it is as *string*! `one_shot` attribute expects
boolean, not a string. The sample in the documentation *was* wrong (it
is fixed now).