commit 28cc2ed: [Minor] Use single quotes rather than escapes

moisseev moiseev at mezonplus.ru
Mon Jul 29 17:49:33 UTC 2024


Author: moisseev
Date: 2023-12-03 17:03:39 +0300
URL: https://github.com/rspamd/rspamd/commit/28cc2ed5fb4ed26649d4fa2f8eae25a3449f6b5a

[Minor] Use single quotes rather than escapes

---
 interface/js/app/symbols.js | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/interface/js/app/symbols.js b/interface/js/app/symbols.js
index d35715188..fdc31f3e6 100644
--- a/interface/js/app/symbols.js
+++ b/interface/js/app/symbols.js
@@ -30,7 +30,7 @@ define(["jquery", "app/rspamd", "footable"],
         const ui = {};
 
         function saveSymbols(action, id, server) {
-            const inputs = $("#" + id + " :input[data-role=\"numerictextbox\"]");
+            const inputs = $("#" + id + ' :input[data-role="numerictextbox"]');
             const url = action;
             const values = [];
             $(inputs).each(function () {
@@ -75,10 +75,9 @@ define(["jquery", "app/rspamd", "footable"],
                     } else if (item.weight > 0) {
                         label_class = "scorebar-spam";
                     }
-                    item.weight = "<input class=\"form-control input-sm mb-disabled " + label_class +
-                    "\" data-role=\"numerictextbox\" autocomplete=\"off\" type=\"number\"" +
-                    " step=\"0.01\" tabindex=\"1\" value=\"" + formatter.format(item.weight) +
-                    "\" id=\"_sym_" + item.symbol + "\"></input>";
+                    item.weight = '<input class="form-control input-sm mb-disabled ' + label_class +
+                        '" data-role="numerictextbox" autocomplete="off" type="number" step="0.01" tabindex="1" ' +
+                        'value="' + formatter.format(item.weight) + '" id="_sym_' + item.symbol + '"></input>';
                     if (!item.time) {
                         item.time = 0;
                     }
@@ -93,12 +92,10 @@ define(["jquery", "app/rspamd", "footable"],
                         distinct_groups.push(item.group);
                     }
                     item.save =
-                        "<button data-save=\"" + selected_server +
-                        "\" title=\"Save changes to the selected server\" " +
-                        "type=\"button\" class=\"btn btn-primary btn-sm mb-disabled\">Save</button> " +
-                        "<button data-save=\"All SERVERS" +
-                        "\" title=\"Save changes to all servers\" " +
-                        "type=\"button\" class=\"btn btn-primary btn-sm mb-disabled\">Save in cluster</button>";
+                        '<button data-save="' + selected_server + '" title="Save changes to the selected server" ' +
+                        'type="button" class="btn btn-primary btn-sm mb-disabled">Save</button> ' +
+                        '<button data-save="All SERVERS" title="Save changes to all servers" ' +
+                        'type="button" class="btn btn-primary btn-sm mb-disabled">Save in cluster</button>';
                     items.push(item);
                 });
             });


More information about the Commits mailing list