commit f89cb1d: [Minor] Remove FP producing warning

Vsevolod Stakhov vsevolod at rspamd.com
Sat Feb 11 12:42:05 UTC 2023


Author: Vsevolod Stakhov
Date: 2023-02-11 12:33:25 +0000
URL: https://github.com/rspamd/rspamd/commit/f89cb1d6acbdfde6aacf9878eacb3faf6a22a1d3 (HEAD -> master)

[Minor] Remove FP producing warning

---
 cmake/CompilerWarnings.cmake | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/cmake/CompilerWarnings.cmake b/cmake/CompilerWarnings.cmake
index 629bb6ee1..9092457de 100644
--- a/cmake/CompilerWarnings.cmake
+++ b/cmake/CompilerWarnings.cmake
@@ -20,6 +20,8 @@ CHECK_C_COMPILER_FLAG(-Wimplicit-fallthrough SUPPORT_WIMPLICIT_FALLTHROUGH)
 # Special check for deprecated declarations, as since OpenSSL 3.0 they
 # just poison output for no good reason
 CHECK_C_COMPILER_FLAG(-Wdeprecated-declarations SUPPORT_WDEPRECATED_DECLARATIONS)
+# Disable -Wsuggest-attribute=format: it is too noisy with FPs around fmt C++ library
+CHECK_C_COMPILER_FLAG(-Wsuggest-attribute SUPPORT_WSUGGEST_ATTRIBUTE)
 
 IF(SUPPORT_WEXTRA)
     ADD_COMPILE_OPTIONS("-Wextra")
@@ -78,6 +80,9 @@ ENDIF(SUPPORT_WMISSING_NORETURN)
 IF(SUPPORT_WMISSING_FORMAT_ATTRIBUTE)
     ADD_COMPILE_OPTIONS("-Wmissing-format-attribute")
 ENDIF(SUPPORT_WMISSING_FORMAT_ATTRIBUTE)
+IF(SUPPORT_WSUGGEST_ATTRIBUTE)
+    ADD_COMPILE_OPTIONS("-Wno-suggest-attribute=format")
+ENDIF()
 
 IF(SUPPORT_WDEPRECATED_DECLARATIONS)
     ADD_COMPILE_OPTIONS("-Wno-deprecated-declarations")


More information about the Commits mailing list