commit 1931487: [Minor] Another leak

Vsevolod Stakhov vsevolod at rspamd.com
Sun Aug 20 18:49:06 UTC 2023


Author: Vsevolod Stakhov
Date: 2023-08-20 19:44:57 +0100
URL: https://github.com/rspamd/rspamd/commit/1931487b17059d6c63adf2245c9632384657f89e (HEAD -> master)

[Minor] Another leak

---
 src/fuzzy_storage.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/fuzzy_storage.c b/src/fuzzy_storage.c
index 21c5c271e..23a4f45cd 100644
--- a/src/fuzzy_storage.c
+++ b/src/fuzzy_storage.c
@@ -2227,7 +2227,7 @@ rspamd_fuzzy_maybe_load_ratelimits(struct rspamd_fuzzy_storage_ctx *ctx)
 	if (access(path, R_OK) != -1) {
 		struct ucl_parser *parser = ucl_parser_new(UCL_PARSER_NO_IMPLICIT_ARRAYS | UCL_PARSER_DISABLE_MACRO);
 		if (ucl_parser_add_file(parser, path)) {
-			const ucl_object_t *obj = ucl_parser_get_object(parser);
+			ucl_object_t *obj = ucl_parser_get_object(parser);
 			int loaded = 0;
 
 			if (ucl_object_type(obj) == UCL_ARRAY) {
@@ -2274,11 +2274,13 @@ rspamd_fuzzy_maybe_load_ratelimits(struct rspamd_fuzzy_storage_ctx *ctx)
 					}
 				}
 
-				ucl_parser_free(parser);
-
 				msg_info("loaded %d ratelimit objects", loaded);
 			}
+
+			ucl_object_unref(obj);
 		}
+
+		ucl_parser_free(parser);
 	}
 }
 


More information about the Commits mailing list