commit 059e2e6: [Test] Remove test case with non-deterministic result

Petr Vaněk arkamar at atlas.cz
Sat Nov 5 12:14:03 UTC 2022


Author: Petr Vaněk
Date: 2022-11-05 10:19:57 +0100
URL: https://github.com/rspamd/rspamd/commit/059e2e69731c599d887a68356662fcf196d8a715 (refs/pull/4323/head)

[Test] Remove test case with non-deterministic result
Removed test case does not work with luajit-2.1 anymore as it depends on
internal behavior of lujait-2.0.

The order of URL list returned by `extract_specific_urls` function from
`lualib/lua_util` depends on order of keys in table of TLDs.  The test
case incorrectly expects "net" and "com" being in front of the table,
however, "org" can appear there as well.

---
 test/lua/unit/lua_util.extract_specific_urls.lua | 1 -
 1 file changed, 1 deletion(-)

diff --git a/test/lua/unit/lua_util.extract_specific_urls.lua b/test/lua/unit/lua_util.extract_specific_urls.lua
index 05ffeb7b0..a7e2f9f48 100644
--- a/test/lua/unit/lua_util.extract_specific_urls.lua
+++ b/test/lua/unit/lua_util.extract_specific_urls.lua
@@ -108,7 +108,6 @@ context("Lua util - extract_specific_urls plain", function()
   local cases = {
     {expect = url_list, filter = nil, limit = 9999, need_emails = true, prefix = 'p'},
     {expect = {}, filter = (function() return false end), limit = 9999, need_emails = true, prefix = 'p'},
-    {expect = {"domain4.co.net", "test.com"}, filter = nil, limit = 2, need_emails = true, prefix = 'p'},
     {expect = {"domain4.co.net", "test.com", "domain3.org"}, filter = nil, limit = 3, need_emails = true, prefix = 'p'},
     {
       expect = {"gov.co.net", "tesco.co.net", "domain1.co.net", "domain2.co.net", "domain3.co.net", "domain4.co.net"},


More information about the Commits mailing list