commit b714690: [Minor] Fix error path varargs handling

Vsevolod Stakhov vsevolod at highsecure.ru
Fri Sep 17 20:35:04 UTC 2021


Author: Vsevolod Stakhov
Date: 2021-09-17 21:33:01 +0100
URL: https://github.com/rspamd/rspamd/commit/b7146906059d461da0e739978c559cefc3afe371 (HEAD -> master)

[Minor] Fix error path varargs handling
Found by: coverity

---
 src/lua/lua_common.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/lua/lua_common.c b/src/lua/lua_common.c
index ee29f9b9d..cd557f816 100644
--- a/src/lua/lua_common.c
+++ b/src/lua/lua_common.c
@@ -2623,6 +2623,7 @@ rspamd_lua_universal_pcall (lua_State *L, gint cbref, const gchar* strloc,
 			g_set_error (err, lua_error_quark (), EINVAL,
 					"invalid argument character: %c at %s",
 					*argp, argp);
+			va_end (ap);
 
 			return false;
 		}
@@ -2635,6 +2636,7 @@ rspamd_lua_universal_pcall (lua_State *L, gint cbref, const gchar* strloc,
 				"error when calling lua function from %s: %s",
 				strloc, lua_tostring (L, -1));
 		lua_settop (L, err_idx - 1);
+		va_end (ap);
 
 		return false;
 	}


More information about the Commits mailing list