commit 4251918: [Minor] Remove bogus forward for non-forwarding reference

Vsevolod Stakhov vsevolod at highsecure.ru
Wed Oct 6 08:56:06 UTC 2021


Author: Vsevolod Stakhov
Date: 2021-10-06 09:54:49 +0100
URL: https://github.com/rspamd/rspamd/commit/4251918a1ab758f545bd1d5dc5e298016e1b6bca (HEAD -> master)

[Minor] Remove bogus forward for non-forwarding reference

---
 src/libmime/mime_string.hxx | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/libmime/mime_string.hxx b/src/libmime/mime_string.hxx
index c6041a778..94bdafb02 100644
--- a/src/libmime/mime_string.hxx
+++ b/src/libmime/mime_string.hxx
@@ -268,7 +268,7 @@ public:
 	basic_mime_string() noexcept : Allocator() {}
 	explicit basic_mime_string(const Allocator& alloc) noexcept : Allocator(alloc) {}
 	explicit basic_mime_string(filter_type &&filt, const Allocator& alloc = Allocator()) noexcept :
-		Allocator(alloc), filter_func(std::forward<filter_type>(filt)) {}
+		Allocator(alloc), filter_func(std::move(filt)) {}
 
 	basic_mime_string(const CharT* str, std::size_t sz, const Allocator& alloc = Allocator()) noexcept :
 			Allocator(alloc)
@@ -296,7 +296,7 @@ public:
 					  filter_type &&filt,
 					  const Allocator& alloc = Allocator()) noexcept :
 			Allocator(alloc),
-			filter_func(std::forward<filter_type>(filt))
+			filter_func(std::move(filt))
 	{
 		append_c_string_filtered(str, sz);
 	}
@@ -304,11 +304,11 @@ public:
 	basic_mime_string(const storage_type &st,
 					  filter_type &&filt,
 					  const Allocator& alloc = Allocator()) noexcept :
-			basic_mime_string(st.data(), st.size(), std::forward<filter_type>(filt), alloc) {}
+			basic_mime_string(st.data(), st.size(), std::move(filt), alloc) {}
 	basic_mime_string(const view_type &st,
 					  filter_type &&filt,
 					  const Allocator& alloc = Allocator()) noexcept :
-			basic_mime_string(st.data(), st.size(), std::forward<filter_type>(filt), alloc) {}
+			basic_mime_string(st.data(), st.size(), std::move(filt), alloc) {}
 
 	constexpr auto size() const noexcept -> std::size_t {
 		return storage.size();


More information about the Commits mailing list