commit d07edfa: [Minor] Disable headers hash for statistics

Vsevolod Stakhov vsevolod at highsecure.ru
Tue Apr 6 14:42:04 UTC 2021


Author: Vsevolod Stakhov
Date: 2021-04-06 15:39:19 +0100
URL: https://github.com/rspamd/rspamd/commit/d07edfa195c7e166cee4b30e7dea6c17a12e169b

[Minor] Disable headers hash for statistics
Discussed with: @moisseev

---
 lualib/lua_stat.lua | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lualib/lua_stat.lua b/lualib/lua_stat.lua
index 2606a8d22..920f20205 100644
--- a/lualib/lua_stat.lua
+++ b/lualib/lua_stat.lua
@@ -678,6 +678,10 @@ local function get_mime_stat_tokens(task, res, i)
 end
 
 local function get_headers_stat_tokens(task, cf, res, i)
+  --[[
+  -- As discussed with Alexander Moisseev, this feature can skew statistics
+  -- especially when learning is separated from scanning, so learning
+  -- has a different set of tokens where this token can have too high weight
   local hdrs_cksum = task:get_mempool():get_variable("headers_hash")
 
   if hdrs_cksum then
@@ -686,6 +690,7 @@ local function get_headers_stat_tokens(task, cf, res, i)
         res[i])
     i = i + 1
   end
+  ]]--
 
   for k,hdrs in pairs(cf.classify_headers_parsed) do
     for _,hname in ipairs(hdrs) do


More information about the Commits mailing list