commit aa13e41: [Minor] silence -Wmisleading-indentation in contrib/snowball/

Christian Göttsche cgzones at googlemail.com
Fri Jan 17 16:07:06 UTC 2020


Author: Christian Göttsche
Date: 2020-01-16 14:57:46 +0100
URL: https://github.com/rspamd/rspamd/commit/aa13e41e5fd47f386f308cfe38561cfa94c2b16e

[Minor] silence -Wmisleading-indentation in contrib/snowball/
../contrib/snowball/compiler/analyser.c: In function ‘check_name_type’:
../contrib/snowball/compiler/analyser.c:210:19: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  210 |         case 'r': if (p->type == t_routine ||
      |                   ^~
../contrib/snowball/compiler/analyser.c:211:54: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  211 |                       p->type == t_external) return; break;
      |                                                      ^~~~~
../contrib/snowball/compiler/analyser.c: In function ‘read_program’:
../contrib/snowball/compiler/analyser.c:859:21: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  859 |                     if (q->used && q->definition == 0) error4(a, q); break;
      |                     ^~
../contrib/snowball/compiler/analyser.c:859:70: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  859 |                     if (q->used && q->definition == 0) error4(a, q); break;
      |                                                                      ^~~~~
../contrib/snowball/compiler/analyser.c:861:21: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  861 |                     if (q->used && q->grouping == 0) error4(a, q); break;
      |                     ^~
../contrib/snowball/compiler/analyser.c:861:68: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  861 |                     if (q->used && q->grouping == 0) error4(a, q); break;
      |                                                                    ^~~~~

---
 contrib/snowball/compiler/analyser.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/contrib/snowball/compiler/analyser.c b/contrib/snowball/compiler/analyser.c
index 68c0d2d90..ed712f64f 100644
--- a/contrib/snowball/compiler/analyser.c
+++ b/contrib/snowball/compiler/analyser.c
@@ -207,8 +207,7 @@ static void check_name_type(struct analyser * a, struct name * p, int type) {
         case 'i': if (p->type == t_integer) return; break;
         case 'b': if (p->type == t_boolean) return; break;
         case 'R': if (p->type == t_grouping) return;
-        case 'r': if (p->type == t_routine ||
-                      p->type == t_external) return; break;
+        case 'r': if (p->type == t_routine || p->type == t_external) return; break;
         case 'g': if (p->type == t_grouping) return; break;
     }
     error2(a, 33, type);
@@ -856,9 +855,9 @@ extern void read_program(struct analyser * a) {
         until (q == 0) {
             switch(q->type) {
                 case t_external: case t_routine:
-                    if (q->used && q->definition == 0) error4(a, q); break;
+                    if (q->used && q->definition == 0) { error4(a, q); } break;
                 case t_grouping:
-                    if (q->used && q->grouping == 0) error4(a, q); break;
+                    if (q->used && q->grouping == 0) { error4(a, q); } break;
             }
             q = q->next;
         }


More information about the Commits mailing list