commit ea826b7: [Minor] Improve error message when learning with passthrough result

Vsevolod Stakhov vsevolod at highsecure.ru
Wed Aug 12 18:07:06 UTC 2020


Author: Vsevolod Stakhov
Date: 2020-08-12 19:05:29 +0100
URL: https://github.com/rspamd/rspamd/commit/ea826b71491fbc6e061b195b4d8bdb9c4b34711b (HEAD -> master)

[Minor] Improve error message when learning with passthrough result
Issue: #3339

---
 src/libstat/stat_process.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/libstat/stat_process.c b/src/libstat/stat_process.c
index aed588073..9cd425206 100644
--- a/src/libstat/stat_process.c
+++ b/src/libstat/stat_process.c
@@ -679,6 +679,16 @@ rspamd_stat_backends_learn (struct rspamd_stat_ctx *st_ctx,
 
 			if (bk_run == NULL) {
 				/* XXX: must be error */
+				if (task->result->passthrough_result) {
+					/* Passthrough email, cannot learn */
+					g_set_error (err, rspamd_stat_quark (), 500,
+							"Cannot learn statistics when passthrough "
+							"result has been set; not classified");
+
+					res = FALSE;
+					goto end;
+				}
+
 				msg_warn_task ("no runtime for backend %s; classifier %s; symbol %s",
 						st->backend->name, cl->cfg->name, st->stcf->symbol);
 				continue;


More information about the Commits mailing list