commit 3b92c50: [Minor] Try to fix use after free

Vsevolod Stakhov vsevolod at highsecure.ru
Wed Oct 2 16:56:06 UTC 2019


Author: Vsevolod Stakhov
Date: 2019-10-02 17:47:46 +0100
URL: https://github.com/rspamd/rspamd/commit/3b92c509518cf97da58bde92231f8745ad07c8d0 (HEAD -> master)

[Minor] Try to fix use after free

---
 src/rspamd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/rspamd.c b/src/rspamd.c
index 95cc2bd6b..8480f6c48 100644
--- a/src/rspamd.c
+++ b/src/rspamd.c
@@ -1060,8 +1060,6 @@ rspamd_cld_handler (EV_P_ ev_child *w, struct rspamd_main *rspamd_main,
 	cmd.cmd.child_change.additional = w->rstatus;
 	rspamd_control_broadcast_srv_cmd (rspamd_main, &cmd, wrk->pid);
 
-	REF_RELEASE (wrk->cf);
-
 	if (wrk->finish_actions) {
 		g_ptr_array_free (wrk->finish_actions, TRUE);
 	}
@@ -1083,6 +1081,7 @@ rspamd_cld_handler (EV_P_ ev_child *w, struct rspamd_main *rspamd_main,
 				wrk->pid);
 	}
 
+	REF_RELEASE (wrk->cf);
 	g_free (wrk);
 }
 


More information about the Commits mailing list